Skip to content

Conversation

ktnielse
Copy link
Member

@ktnielse ktnielse commented Oct 9, 2026

Replaces the per-page headers with one persistent site header, so the main navigation is available on every page without going through the home page.

What's included

  • Shared header (SiteHeader, PageHeader) rendered once in App, so it stays mounted while navigating. Only the title, subtitle and help text change per page. The current page is highlighted from the route.
  • Uniform size: the banner has the same height on every page, and the title is one line with a fixed height. The map page gets the same banner, with the map below it.
  • Smaller navigation buttons to keep the banner compact, with the same look as before.
  • Sea gradient on the banner and a wave edge that hangs below it, so it blends with both the page background and the map (fixes the white line above the map).
  • Removed the "Hovedside" button and the HomeLink component.
  • Smoother page changes: each page starts at the top and fades in. Fetched data (places, challenges, user) is cached with useFetch, so returning to a page does not flash a loading state. The map page now uses fetchAllPlaces instead of its own fetch code.
  • Sailing quote at the bottom of every page (PageFooter).
  • Wheel design: simplified the ship's wheel (fewer details, no gaps between segments).
  • Bug fix: effects no longer return the result of scrollTo / the spin callback, which made React crash with "destroy is not a function" in some browsers.

Notes

  • Stacked on feat/challenges-page, so this PR targets that branch until the earlier PRs are merged.
  • The map page is now taller than the viewport (header above the map), so you scroll a little to see all of it.

Kasper added 8 commits October 8, 2026 17:26
Setter opp Vite, React og TypeScript i client/ med Prettier og oxlint.

Hovedside:
- Header med burgermeny, hjelpeboble og navigasjon
- Fremhevet sted med Forrige/Neste og kompass-lenke til nettsiden
- Forslagsliste med Vis mer og Vis mindre
- Åpent (grønt) og Stengt (rødt) ut fra åpningstid

Data hentes via fetchPlaces() med mockdata, så den kan byttes ut med GraphQL-backenden senere.
Add a stylized SVG map of Trondheim that can be panned and zoomed, with a pin for each place. Add a left-hand panel with search and a fixed-size detail view with a back arrow. Add hash-based routing, make Utforsk in the main navigation open the map, and add coordinates to Place.
Add a user page with profile header, a scrollable favourite places row, an empty favourite routes section and badge slots. Add a user route, a mock current user behind fetchCurrentUser and the gulls from the home page.
@ktnielse ktnielse requested a review from a team as a code owner October 9, 2026 14:37
alekskjo
alekskjo previously approved these changes Oct 10, 2026
Copy link
Member

@alekskjo alekskjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ser bra ut! Den felles headeren og navigasjonen gjør sidene mer sammenhengende, og oppryddingen reduserer duplisert kode på tvers av sidene.
Testet også navigasjonen lokalt i Safari. Godkjent ✅

@ktnielse ktnielse dismissed alekskjo’s stale review October 10, 2026 07:31

The merge-base changed after approval.

alekskjo
alekskjo previously approved these changes Oct 10, 2026
@ktnielse ktnielse dismissed alekskjo’s stale review October 10, 2026 07:37

The merge-base changed after approval.

@alekskjo
Copy link
Member

Superseded by #44.

The implementation is preserved in the replacement PR, which was created from the latest main and contains only the intended shared header and navigation changes.

@alekskjo alekskjo closed this Oct 10, 2026
Sign in to join this conversation on GitHub.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants