refactor: shared site header and sailing quotes #43
+6,753
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces the per-page headers with one persistent site header, so the main navigation is available on every page without going through the home page.
What's included
SiteHeader,PageHeader) rendered once inApp, so it stays mounted while navigating. Only the title, subtitle and help text change per page. The current page is highlighted from the route.HomeLinkcomponent.useFetch, so returning to a page does not flash a loading state. The map page now usesfetchAllPlacesinstead of its own fetch code.PageFooter).scrollTo/ the spin callback, which made React crash with "destroy is not a function" in some browsers.Notes
feat/challenges-page, so this PR targets that branch until the earlier PRs are merged.